[PATCH] Use long wherever possible in mpa.c
Andreas Jaeger
aj@suse.com
Thu Feb 21 09:46:00 GMT 2013
On 02/21/2013 10:40 AM, Siddhesh Poyarekar wrote:
> On Thu, Feb 21, 2013 at 10:32:09AM +0100, Andreas Jaeger wrote:
>> On 02/21/2013 10:23 AM, Siddhesh Poyarekar wrote:
>>> Hi,
>>>
>>> Here's another patch to sync up code between powrpc and generic mpa.c,
>>> this time the change being in the generic code. Using long throughout
>>> like powerpc does is beneficial since it reduces the need to switch to
>>> 32-bit instructions. It gives a very minor performance improvement
>>> (~0.4%). OK to commit?
>>
>> Have you done any measurements on 32-bit architectures? What's the result?
>
> It has worked fine on powerpc32. x86 does not use mpa, so there's no
> way to test on it. I don't have access to any other 32-bit hardware,
> but this should not hurt anything that is ILP32 since long will be
> 32-bit anyway.
Ok, then go ahead,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
More information about the Libc-alpha
mailing list