[PATCH] Use long wherever possible in mpa.c

Siddhesh Poyarekar siddhesh@redhat.com
Thu Feb 21 09:39:00 GMT 2013


On Thu, Feb 21, 2013 at 10:32:09AM +0100, Andreas Jaeger wrote:
> On 02/21/2013 10:23 AM, Siddhesh Poyarekar wrote:
> >Hi,
> >
> >Here's another patch to sync up code between powrpc and generic mpa.c,
> >this time the change being in the generic code.  Using long throughout
> >like powerpc does is beneficial since it reduces the need to switch to
> >32-bit instructions.  It gives a very minor performance improvement
> >(~0.4%).  OK to commit?
> 
> Have you done any measurements on 32-bit architectures? What's the result?

It has worked fine on powerpc32.  x86 does not use mpa, so there's no
way to test on it.  I don't have access to any other 32-bit hardware,
but this should not hurt anything that is ILP32 since long will be
32-bit anyway.


Siddhesh



More information about the Libc-alpha mailing list