PATCH: Add x32 support to sysdeps/x86_64/dl-tlsdesc.h

[H.J. Lu]

On Thu, Mar 22, 2012 at 9:58 AM, Roland McGrath <roland@hack.frob.com> wrote:
> I think the bit using the union warrants a comment explaining why it's there.
>
>>       * sysdeps/x86_64/dl-tlsdesc.h (tlsdesc): Use anonymouse union
>
> typo: s/anonymouse/anonymous/
>
>> +      ptrdiff_t (*entry)(struct tlsdesc *on_rax);
>
> Missing space before paren.
>
> With those nits fixed, I'm happy with the change.
> But I'd be happier yet if other people gave opinions
> about the union trick vs explicit #ifdef's padding fields.
>
>

Here is an updated patch.  Does anyone have any preference of
anonymous union vs. explicit #ifdef's padding fields?  My opinion
is we can go anonymous union for now.  We can always change
it to explicit #ifdef's padding fields if it is a real issue.  Any comments?

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libc-dl-tlsdesc.patch
Type: text/x-patch
Size: 931 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20120323/53188d9d/attachment.bin>