PATCH: Add x32 support to sysdeps/x86_64/dl-tlsdesc.h

Roland McGrath roland@hack.frob.com
Thu Mar 22 16:58:00 GMT 2012


I think the bit using the union warrants a comment explaining why it's there.

> 	* sysdeps/x86_64/dl-tlsdesc.h (tlsdesc): Use anonymouse union

typo: s/anonymouse/anonymous/

> +      ptrdiff_t (*entry)(struct tlsdesc *on_rax);

Missing space before paren.

With those nits fixed, I'm happy with the change.
But I'd be happier yet if other people gave opinions
about the union trick vs explicit #ifdef's padding fields.


Thanks,
Roland



More information about the Libc-alpha mailing list