PATCH: Support multiarch for i686

H.J. Lu hjl.tools@gmail.com
Fri Jul 31 13:52:00 GMT 2009


On Thu, Jul 30, 2009 at 10:05 PM, Ulrich Drepper<drepper@redhat.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> H.J. Lu wrote:
>
>> +#ifdef __x86_64__
>
> Don't do that.  Define a macro in the i386 version saying this info
> isn't wanted and then test it here.  Correct all the places where you
> use this type of #ifdef.

I will do it.

>
>> @@ -530,9 +522,7 @@ init_cacheinfo (void)
>>         /* Query until desired cache level is enumerated.  */
>>         do
>>           {
>> -              asm volatile ("cpuid"
>> -                         : "=a" (eax), "=b" (ebx), "=c" (ecx), "=d" (edx)
>> -                         : "0" (4), "2" (i++));
>> +           __cpuid_count (4, i++, eax, ebx, ecx, edx);
>
> __cpuid_count is a bit too recent.  Not even gcc 4.3 has it.
>

Should it check __cpuid_count or provide __cpuid_count if not available?

Thanks.

-- 
H.J.



More information about the Libc-alpha mailing list