PATCH: Support multiarch for i686

Ulrich Drepper drepper@redhat.com
Fri Jul 31 11:45:00 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

H.J. Lu wrote:

> +#ifdef __x86_64__

Don't do that.  Define a macro in the i386 version saying this info
isn't wanted and then test it here.  Correct all the places where you
use this type of #ifdef.


> @@ -530,9 +522,7 @@ init_cacheinfo (void)
>  	  /* Query until desired cache level is enumerated.  */
>  	  do
>  	    {
> -              asm volatile ("cpuid"
> -		            : "=a" (eax), "=b" (ebx), "=c" (ecx), "=d" (edx)
> -		            : "0" (4), "2" (i++));
> +	      __cpuid_count (4, i++, eax, ebx, ecx, edx);

__cpuid_count is a bit too recent.  Not even gcc 4.3 has it.

- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkpye4oACgkQ2ijCOnn/RHTw2QCfSZDMbDlywdP39v6iSgX20bLz
G1wAoKLDQnbaj+NhBcALpNRVB+lVOxkr
=ga+d
-----END PGP SIGNATURE-----



More information about the Libc-alpha mailing list