Two quick questions

Christopher Faylor cgf-use-the-mailinglist-please@sourceware.org
Mon Nov 28 22:09:00 GMT 2011


On Mon, Nov 28, 2011 at 07:38:09AM -0800, Joel Brobecker wrote:
>>      1. Since neither
>>      http://www.sourceware.org/gdb/current/onlinedocs/gdbint/Coding-Standards.html
>>      nor http://sourceware.org/gdb/wiki/JoelsCodingStyleCheatSheet
>>      mentions this, or at least yours myopic truly haven't noticed it,
>>      I wonder what is the GDB's allegiance in the Tabs, Spaces, Tabs +
>>      Spaces holy war? Who are the infidels we must crush? :) The
>>      reason I'm asking is that I don't want to generate false diffs
>>      just because I re-indented the line in different style.
>
>We use tabs mostly, optionally followed by spaces if a line of code
>doesn't exactly start at a tabulation. Although it's perfectly fine
>to tabify a line of code that you're modifying, I would personally
>prefer that you don't touch lines just for the sake of tabifying.
>Others might disagree (hence the "personally"), but these little
>changes don't bring anything in terms of readability, mess up the
>indentation when reading diffs, and also potentially create merge
>conflicts for changes that are essentially no-ops.

I think most people would agree that gratuitously reindenting lines that
haven't been touched is really a bad idea.

>>      Where is that "gdb GNATS bug reporting database"? I can't help but
>>      feel guilty for being a security threat, but I just can't find it.
>>      There is a Bugzilla, I've seen it, but those two don't seem to be
>>      related.
>
>I don't know much about that one, and who might have created an
>account for you. For GDB, we've transitioned to buzilla, as you
>have found. We used to use gnats, but no more.

Wow, that's ancient.  I need to move that message into the 21st century.
Also, I suspect that the script shouldn't be creating bugzilla accounts
at all.

cgf



More information about the Gdb mailing list