[PATCH v2 06/29] Avoid duplicate QThreadEvents packets

Simon Marchi simark@simark.ca
Thu Jul 21 02:30:23 GMT 2022



On 2022-07-13 18:24, Pedro Alves wrote:
> Similarly to QProgramSignals and QPassSignals, avoid sending duplicate
> QThreadEvents packets.
> 
> Change-Id: Iaf5babb0b64e1527ba4db31aac8674d82b17e8b4
> ---
>  gdb/remote.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/gdb/remote.c b/gdb/remote.c
> index c0bd075e9e5..00ed82dc466 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -314,6 +314,10 @@ class remote_state
>       the target know about program signals list changes.  */
>    char *last_program_signals_packet = nullptr;
>  
> +  /* Similarly, the last QThreadEvents state we sent to the
> +     target.  */
> +  bool last_thread_events;

This field is read before it is ever set, isn't it bad?

Simon


More information about the Gdb-patches mailing list