[PATCH v2 06/29] Avoid duplicate QThreadEvents packets
Pedro Alves
pedro@palves.net
Wed Jul 13 22:24:10 GMT 2022
Similarly to QProgramSignals and QPassSignals, avoid sending duplicate
QThreadEvents packets.
Change-Id: Iaf5babb0b64e1527ba4db31aac8674d82b17e8b4
---
gdb/remote.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/gdb/remote.c b/gdb/remote.c
index c0bd075e9e5..00ed82dc466 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -314,6 +314,10 @@ class remote_state
the target know about program signals list changes. */
char *last_program_signals_packet = nullptr;
+ /* Similarly, the last QThreadEvents state we sent to the
+ target. */
+ bool last_thread_events;
+
gdb_signal last_sent_signal = GDB_SIGNAL_0;
bool last_sent_step = false;
@@ -14584,6 +14588,9 @@ remote_target::thread_events (int enable)
if (packet_support (PACKET_QThreadEvents) == PACKET_DISABLE)
return;
+ if (rs->last_thread_events == enable)
+ return;
+
xsnprintf (rs->buf.data (), size, "QThreadEvents:%x", enable ? 1 : 0);
putpkt (rs->buf);
getpkt (&rs->buf, 0);
@@ -14594,6 +14601,7 @@ remote_target::thread_events (int enable)
case PACKET_OK:
if (strcmp (rs->buf.data (), "OK") != 0)
error (_("Remote refused setting thread events: %s"), rs->buf.data ());
+ rs->last_thread_events = enable;
break;
case PACKET_ERROR:
warning (_("Remote failure reply: %s"), rs->buf.data ());
--
2.36.0
More information about the Gdb-patches
mailing list