[PATCH 4/4] mi-sym-info.exp: Increase timeout for 114-symbol-info-functions

[Kevin Buettner]

On Fri, 11 Jun 2021 16:11:31 -0400
Simon Marchi <simon.marchi@polymtl.ca> wrote:

> On 2021-06-10 1:26 p.m., Kevin Buettner via Gdb-patches wrote:
> > Loading libc.so's symbols increased the amount of time needed for
> > 114-symbol-info-function to fetch symbols, causing a timeout during my
> > testing.  I enclosed the entire block with a "with_timeout_factor 4",
> > which fixes the problem for me.  (Using 2 also fixed it for me, but it
> > might not be enough when running this test on slower machines.)
> > 
> > gdb/testsuite/ChangeLog:
> > 
> > 	* gdb.mi/mi-sym-info.exp (114-symbol-info-function test): Increase
> > 	timeout.  
> 
> This LGTM - as long as you can confirm that this is a case of "GDB
> thinking for a long time before outputting something", 

Yes, confirmed.

> and not a case of
> "there's a lot of output and we are trying to chew too much in a single
> match".  But it looks like the test is already written to consume little
> chunks at a time, since:
> 
>     https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2d61316c32a9fa3e14786c3312d9ca87c9298db5
> 

Agreed.

Kevin