[PATCH 4/4] mi-sym-info.exp: Increase timeout for 114-symbol-info-functions

[Simon Marchi]

On 2021-06-10 1:26 p.m., Kevin Buettner via Gdb-patches wrote:
> Loading libc.so's symbols increased the amount of time needed for
> 114-symbol-info-function to fetch symbols, causing a timeout during my
> testing.  I enclosed the entire block with a "with_timeout_factor 4",
> which fixes the problem for me.  (Using 2 also fixed it for me, but it
> might not be enough when running this test on slower machines.)
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.mi/mi-sym-info.exp (114-symbol-info-function test): Increase
> 	timeout.

This LGTM - as long as you can confirm that this is a case of "GDB
thinking for a long time before outputting something", and not a case of
"there's a lot of output and we are trying to chew too much in a single
match".  But it looks like the test is already written to consume little
chunks at a time, since:

    https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2d61316c32a9fa3e14786c3312d9ca87c9298db5

I'd be curious to try it, but I don't have access to my usual Ubuntu
development machine that has debug info for libc installed (and on the
machine I'm typing this on I can't install them easily).  Anyway, it's
probably fine.

My other comment would be: there are many with_timeout_factor in that
test, I'm thinking we should just wrap the entire test in a single
`with_timeout_factor 4`.

Simon