[rfa] Make get_number_or_range accept value history references

Pedro Alves pedro@codesourcery.com
Sat Feb 26 11:54:00 GMT 2011


On Friday 25 February 2011 21:45:39, Michael Snyder wrote:

> OK, a major re-write!   ;-)

Thanks.

I now noticed linespec.c:decode_dollar also does
the same thing, another candidate for refactoring/reuse.

What does the _ref mean in value_from_history_ref?

> +gdb_test "disable \$1foo" \
> +    "Convenience variable must have integer value.*" \
> +    "disable with badly formed history value"

This is not a badly formed history value.  It's a user
convenience variable.  I'd make the test check that
such convenience variables work as intended.

Otherwise looked fine.  Thanks again.

-- 
Pedro Alves



More information about the Gdb-patches mailing list