[rfa] Make get_number_or_range accept value history references

Michael Snyder msnyder@vmware.com
Sun Feb 27 21:03:00 GMT 2011


Pedro Alves wrote:
> On Friday 25 February 2011 21:45:39, Michael Snyder wrote:
> 
>> OK, a major re-write!   ;-)
> 
> Thanks.
> 
> I now noticed linespec.c:decode_dollar also does
> the same thing, another candidate for refactoring/reuse.

I'll look at it as a separate pass.

> What does the _ref mean in value_from_history_ref?

History reference.

>> +gdb_test "disable \$1foo" \
>> +    "Convenience variable must have integer value.*" \
>> +    "disable with badly formed history value"
> 
> This is not a badly formed history value.  It's a user
> convenience variable.  I'd make the test check that
> such convenience variables work as intended.

I did add such a test.

> Otherwise looked fine.  Thanks again.


Committed.



More information about the Gdb-patches mailing list