gethostname() patch

Sergey Okhapkin sos@sokhapkin.dyndns.org
Fri Jan 10 12:21:00 GMT 2003


Two notes:

1. Why do you call set_winsock_errno() but not set_errno() if
GetComputerName() failed?
2. You're comparing the return value of gethostname() with SOCKET_ERROR.
What the return value will be if TCPIP is not installed?

Sergey Okhapkin
Somerset, NJ
----- Original Message -----
From: "Corinna Vinschen" <vinschen@redhat.com>
To: <cygwin-developers@cygwin.com>
Sent: Friday, January 10, 2003 7:02 AM
Subject: gethostname() patch


> Hi,
>
> I've just removed some old cruft from cygwin_gethostname which had
> the annoying result that always the return value of GetComputerName()
> has been used instead of the return value of gethostname().  Now
> Cygwin's gethostname and hostname(1) report the winsock value of the
> hostname which is lower case.
>
> My questions is:  Shouldn't uname call this function as well?  Uname
> still uses the upper case value returned from GetComputerName().
>
> Corinna
>
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Developer                                mailto:cygwin@cygwin.com
> Red Hat, Inc.
>




More information about the Cygwin-developers mailing list