cinstall patch

Matt matt@use.net
Sat Oct 27 20:00:00 GMT 2001


2001-10-27  Matt Hargett  <matt@use.net>

	* geturl.cc (progress): Change int to unsigned int to eliminate
	lint warnings.

	* (get_url_to_string): Check for NULL pointer.

	* mount.cc (find2): Use free instead of delete for malloc'd
	memory.

	* nio-http.cc (NetIO_HTTP::NetIO_HTTP): Fix memory leak.



There were a few lint wanrings I wasn't sure what to do about. The warning
and my question:

geturl.cc(95) : Warning 578: Declaration of symbol 'gw_dialog' hides
symbol
    'gw_dialog' (line 40)

Is this intentional?

----
choose.cc(448) : Warning 533: function 'list_click(struct HWND__ *, int,
int,
    int, unsigned int)' should return a value (see line 402)

what should the return value be at the end of the function?

-----
choose.cc(911) : Warning 644: Variable 'n' (line 891) may not have been
    initialized

what should initial value for n be?

----
          if (src && srcsz)
choose.cc(1488) : Warning 506: Constant value Boolean

Should this be *src && *srcsz?




--
http://www.clock.org/~matt


More information about the Cygwin-developers mailing list