[PATCH v4] binutils/dwarf: Print embedded source, when available

[Will Hawkins]

On Fri, May 15, 2026 at 7:52 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 08.05.2026 13:28, Will Hawkins wrote:
> > Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
> > ---
> >  v4:
> >     Fixed formatting
> >     Fixed namesourcepass scoping
> >     Updated comments
> >     Greatly simplified/commented test case
>
> Much appreciated, as it's much more readable now. Just one other nit below,
> apart from my previously voiced more general concern towards the two new
> enumerators.

I agree -- I appreciate you pushing me to clean it up! I learned a ton
in the process.

>
> > @@ -5872,13 +5876,32 @@ display_formatted_table (unsigned char *data,
> >
> >             READ_ULEB (content_type, format, end);
> >             READ_ULEB (form, format, end);
> > -           bool do_loc = (content_type == DW_LNCT_path) != (namepass == 1);
> > +
> > +           bool do_loc = ((content_type == DW_LNCT_path)
> > +                          != (namesourcepass == 1))
> > +                         | ((content_type == DW_LNCT_LLVM_source
>
> While functionally correct, preferably || in something dealing with any
> yielding boolean. (Likely can be adjusted by whoever ends up committing
> this, assuming there'll be someone to approve it despite my concern.)

Will clean that up, thank you! Also, I have a small tweak to the test
case to make it pass on multiple architectures. Expect a v5 soon!

Thank you, again, for the feedback!
Will


>
> Jan