[PATCH v4] binutils/dwarf: Print embedded source, when available

[Jan Beulich]

On 08.05.2026 13:28, Will Hawkins wrote:
> Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
> ---
>  v4:
>     Fixed formatting
>     Fixed namesourcepass scoping
>     Updated comments
>     Greatly simplified/commented test case

Much appreciated, as it's much more readable now. Just one other nit below,
apart from my previously voiced more general concern towards the two new
enumerators.

> @@ -5872,13 +5876,32 @@ display_formatted_table (unsigned char *data,
>  
>  	      READ_ULEB (content_type, format, end);
>  	      READ_ULEB (form, format, end);
> -	      bool do_loc = (content_type == DW_LNCT_path) != (namepass == 1);
> +
> +	      bool do_loc = ((content_type == DW_LNCT_path)
> +			     != (namesourcepass == 1))
> +			    | ((content_type == DW_LNCT_LLVM_source

While functionally correct, preferably || in something dealing with any
yielding boolean. (Likely can be adjusted by whoever ends up committing
this, assuming there'll be someone to approve it despite my concern.)

Jan