RFC: Annotate immediates in x86 disassembly

Jan Beulich jbeulich@suse.com
Fri May 15 08:42:14 GMT 2026


On 13.05.2026 12:53, Nick Clifton wrote:
>>>> For me the use of the global "exe" in test_objdump_M_annotate is a
>>>> problem when running the testsuite with RUNTESTFLAGS=x86-64.exp:
>>>> ERROR: can't read "exe": no such variable
> 
>>   You just need: 
>> set exe [exeext]
> 
> Thanks Maciej.
> 
> I am happy with either solution.  Jan - can you confirm that one or
> both work, and do you have a preference ?

Maciej's works and is in line with what some parent dir *.exp also do.
I guess I'll commit the patch below right away.

Jan

binutils: make x86-64/x86-64.exp work again by itself

The "exe" global is introduced only by some *.exp in the parent dir, which
may not be run.

--- a/binutils/testsuite/binutils-all/x86-64/x86-64.exp
+++ b/binutils/testsuite/binutils-all/x86-64/x86-64.exp
@@ -28,6 +28,8 @@ foreach t $test_list {
     run_dump_test [file rootname $t]
 }
 
+set exe [exeext]
+
 set t $srcdir/$subdir/pr26808.dwp.bz2
 # We need to strip the ".bz2", but can leave the dirname.
 set test $subdir/[file tail $t]



More information about the Binutils mailing list