[PATCH 01/19] RISC-V: improve .insn documentation

Jan Beulich jbeulich@suse.com
Sun May 3 08:45:42 GMT 2026


On 28.04.2026 03:39, Jiawei wrote:
>> First of all, the "type" form of .insn does not permit (not even
>> optionally) a comma after the type, much like for ordinary insns a comma
>> is not permitted between insn mnemonic and first operand. The example
>> given actually properly shows that already.
>>
>> While there, also update the .word related text: Mapping symbols have been
>> in use for quite some time.
>>
>> --- a/gas/doc/c-riscv.texi
>> +++ b/gas/doc/c-riscv.texi
>> @@ -229,23 +229,22 @@ by rv32imac.
>>  @end table
>>
>>  @cindex INSN directives
>> -@item .insn @var{type}, @var{operand} [,...,@var{operand_n}]
>> +@item .insn @var{type} @var{operand} [,...,@var{operand_n}]
>>  @itemx .insn @var{insn_length}, @var{value}
>>  @itemx .insn @var{value}
>>  This directive permits the numeric representation of an instructions
>>
> 
> LGTM.
> 
> While reading the patch, I noticed one small pre-existing nit:
> 
> "an instructions" could be changed to "an instruction".
> 
> This is not introduced by this patch, though.

I think a later patch corrects that, when touching the textual description.

Jan


More information about the Binutils mailing list