[PATCH] ELF: Properly copy and strip Solaris binaries

[Alan Modra]

On Tue, Jan 27, 2026 at 08:04:41PM +0100, Rainer Orth wrote:
> Hi Alan,
> 
> > The following is what is left over from
> > https://sourceware.org/pipermail/binutils/2025-December/146789.html
> >
> > Please cast your eye over this HJ, it is mostly your patch.  Rainer,
> > if you commit your ld_supports_emul patch soon I'll update the
> > "ld -V -m" here before committing.
> 
> done now.
> 
> Just a few comments and questions on the patch:
> 
> * The ChangeLog should refer to PR binutils/33718 so the commit shows up
>   in there

It is sufficient to put "PR 33718" in the subject.  Note that you
need the space.

> * I wonder why neither the PR nor the patch refer to the extensive
>   discussion of the issue in PR binutils/33684 which prompted this PR
>   and patch.

Added to the patch.

> * Neither the patch names nor the filenames carry any meaning.  I think
>   they should be way more descriptive instead.
> 
> * Besides, I wonder about dropping arbitrary objects into the testsuite.
>   I suspect it would be way better to rely on native testing for issues
>   like this, so we could both extend testing to all of Solaris/SPARC and
>   x86, 32 and 64-bit.  Besides, it would be possible to run elfdump >
>   /dev/null on the objects which is an excellent first sanity check for
>   all kinds of objects on Solaris.
> 
>   After all, we're just one PR away from clean Solaris testresults as a
>   prerequisite for setting up such bots :-)

OK, I'll remove the testcase and just commit the objcopy.c part.

-- 
Alan Modra