[PATCH] binutils: Require GNU tail for 'objdump -Wi' test

[H.J. Lu]

On Wed, Sep 10, 2025 at 1:49 AM Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>
> Hi Maciej,
>
> > On Sun, 7 Sep 2025, H.J. Lu wrote:
> >
> >> But the default Solaris tail doesn't support "tail -n +4".  Add
> >> ACX_PROG_GNU_TAIL to use GNU tail for 'objdump -Wi' test.
> >
> >  POSIX has had it from time immemorial.  Don't you just need to request a
> > POSIX `tail' implementation on Solaris instead (via $PATH or otherwise)?
>
> AFAICS it's easier and more reliable to fall back to traditional tail
> options that work across the board:
>
> tail +4l works with Solaris /usr/bin/tail, GNU tail, and FreeBSD
> /usr/bin/tail.
>
> The current patch is not only way too complicated, but also breaks
> FreeBSD testing badly:
>
> ERROR: tcl error sourcing /vol/src/gnu/binutils/hg/master/local/binutils/testsuite/binutils-all/objdump.exp.
> ERROR: tcl error code POSIX ENOENT {no such file or directory}
> ERROR: could not read "objdump.tail": no such file or directory
> UNRESOLVED: testcase '/vol/src/gnu/binutils/hg/master/local/binutils/testsuite/binutils-all/objdump.exp' aborted due to Tcl error
>
> binutils.log shows
>
> Executing on host:  -n +4 tmpdir/objdump.out  /dev/null tmpdir/objdump.tail (tim
> eout = 300)
> ERROR: tcl error sourcing /vol/src/gnu/binutils/hg/master/local/binutils/testsuite/binutils-all/objdump.exp.
> ERROR: tcl error code POSIX ENOENT {no such file or directory}
> ERROR: could not read "objdump.tail": no such file or directory
>     while executing
> "file size $output"
>     (file "/vol/src/gnu/binutils/hg/master/local/binutils/testsuite/binutils-all/objdump.exp" line 608)
>     invoked from within
> "source /vol/src/gnu/binutils/hg/master/local/binutils/testsuite/binutils-all/objdump.exp"
>     ("uplevel" body line 1)
>     invoked from within
> "uplevel #0 source /vol/src/gnu/binutils/hg/master/local/binutils/testsuite/binutils-all/objdump.exp"
>     invoked from within
> "catch "uplevel #0 source $test_file_name" msg"
> UNRESOLVED: testcase '/vol/src/gnu/binutils/hg/master/local/binutils/testsuite/binutils-all/objdump.exp' aborted due to Tcl error
>
> and binutils/Makefile has
>
> TAIL =
> [...]
>         TAIL=$(TAIL); export TAIL; \
>
>         Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University

I am reverting the commit.

-- 
H.J.