[PATCH v2 06/13] LD/PE: Remove remains of MIPS target support

[Jan Beulich]

On 05.09.2025 18:22, Maciej W. Rozycki wrote:
> On Mon, 1 Sep 2025, Jan Beulich wrote:
> 
>>>> Remove the relevant pieces then, originally from commit 344a211f9995 
>>>> ("Add support for WinCE based toolchains."), including MIPS architecture 
>>>> parts and HIGHADJ relocation support in particular.
>>>> ---
>>>> v2 Integrate into series. Retain code generating LOW relocs.
>>>
>>>  NAK for now until I'm back from holiday.
>>
>> First, why? It's your original patch, just with a little less code removed.
> 
>  I actually find it rude to send a modified version of someone else's 
> change without making sure that the discussion has concluded and that the 
> other party having been made aware and acknowledged that this is the way 
> forward intended.  They've put their name on it after all and may not want 
> to authorise the changes.
> 
>  In this case I haven't had an opportunity yet to investigate your
> reference and offhand keeping a piece of code only to satisfy "invalid 
> usage" does not appear justified.  I've run out of time and please mind I 
> do it outside my day job.  Besides, dead code being removed here has been 
> in this state for 20+ years now, so there's no need rushing its removal.  
> World just won't collapse if this code stays there for another fortnight.

Well, I can certainly remove the patch from my series again, as it doesn't
strictly depend on it. But having the tidying go in first seemed preferable
to me, hence why I had hoped for your change to have gone in quite some
time ago. As it didn't, I decided to include it with - and that's imo the
important part - merely applying the review comment I gave. Nothing rude in
here, I don't think.

Removing dead code is of course always desirable. Removing code which
cannot be proven to be dead, otoh, may not be.

>> And then, can you please indicate when (approximately) this is going to be?
> 
>  I'm back now, but I've run out of time this week too.  I'll try to get to 
> it Mon-Wed next week.  I'll appreciate your understanding.

I appreciate this, yet as I'm going to travel from end of this week, I won't
commit my series ahead of that anymore, as I wouldn't be able to deal with
eventual fallout in a timely manner. Hence it'll now be delayed by another
month ...

Jan