[PATCH v2 06/13] LD/PE: Remove remains of MIPS target support
Maciej W. Rozycki
macro@orcam.me.uk
Fri Sep 5 16:22:11 GMT 2025
On Mon, 1 Sep 2025, Jan Beulich wrote:
> >> Remove the relevant pieces then, originally from commit 344a211f9995
> >> ("Add support for WinCE based toolchains."), including MIPS architecture
> >> parts and HIGHADJ relocation support in particular.
> >> ---
> >> v2 Integrate into series. Retain code generating LOW relocs.
> >
> > NAK for now until I'm back from holiday.
>
> First, why? It's your original patch, just with a little less code removed.
I actually find it rude to send a modified version of someone else's
change without making sure that the discussion has concluded and that the
other party having been made aware and acknowledged that this is the way
forward intended. They've put their name on it after all and may not want
to authorise the changes.
In this case I haven't had an opportunity yet to investigate your
reference and offhand keeping a piece of code only to satisfy "invalid
usage" does not appear justified. I've run out of time and please mind I
do it outside my day job. Besides, dead code being removed here has been
in this state for 20+ years now, so there's no need rushing its removal.
World just won't collapse if this code stays there for another fortnight.
"Nothing should be done in haste but gripping a flea."
> I.e. I merely applied my own review comment. I think I'm very well in the
> position to demand retaining of the piece of code, even if it's "just in
> case".
Absolutely, but I think that at the very least it has to be with the
other party having agreed to disagree. And I've been around long enough
for anyone to see that I tend to try and be reasonable and cooperative, so
there's no need to force anything upon me.
> And then, can you please indicate when (approximately) this is going to be?
I'm back now, but I've run out of time this week too. I'll try to get to
it Mon-Wed next week. I'll appreciate your understanding.
Maciej
More information about the Binutils
mailing list