[PATCH] ld: Limit "readelf --got-contents" tests

[H.J. Lu]

On Fri, Sep 5, 2025 at 6:00 AM Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>
> Hi H.J.,
>
> >> > These tests are generic x86 tests, not Linux specific.  If Rainer believes
> >> > that a Solaris specific test is needed, he can add one.
> >>
> >> you still haven't explained why the specific addresses matter at all for
> >> this specific test when they don't for most other similar tests.  Just
> >> asserting they do instead of explaining doesn't help.
> >
> > "readelf --got-contents" dumps indices and addresses.  If the expected
> > outputs are arbitrary values, these tests are ineffective.
>
> you're simply replacing one assertion for another.  Why on earth do the
> actual addresses suddenly matter here when they don't for the vast

While working on --got-contents, I looked at each index and address
closely to make sure that they matched the relocations and GOT
section contents in the input.  You haven't given a reason to explain
why generic tests aren't sufficient and Solaris specific tests are required.

> majority of the other similar tests?  If one of the other binutils
> maintainers can confirm this, fine.  Otherwise, you're only creating
> hurdles for no reason!
>
>         Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University



-- 
H.J.