[PATCH] ld: Limit "readelf --got-contents" tests

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Fri Sep 5 13:00:01 GMT 2025


Hi H.J.,

>> > These tests are generic x86 tests, not Linux specific.  If Rainer believes
>> > that a Solaris specific test is needed, he can add one.
>>
>> you still haven't explained why the specific addresses matter at all for
>> this specific test when they don't for most other similar tests.  Just
>> asserting they do instead of explaining doesn't help.
>
> "readelf --got-contents" dumps indices and addresses.  If the expected
> outputs are arbitrary values, these tests are ineffective.

you're simply replacing one assertion for another.  Why on earth do the
actual addresses suddenly matter here when they don't for the vast
majority of the other similar tests?  If one of the other binutils
maintainers can confirm this, fine.  Otherwise, you're only creating
hurdles for no reason!

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


More information about the Binutils mailing list