[PATCH 18/27] bfd/ELF: adjust *_size_info properties

Jan Beulich jbeulich@suse.com
Tue Oct 28 07:36:55 GMT 2025


On 27.10.2025 18:49, Maciej W. Rozycki wrote:
> On Mon, 27 Oct 2025, Jan Beulich wrote:
> 
>> --- a/bfd/elf64-mips.c
>> +++ b/bfd/elf64-mips.c
>> @@ -4687,7 +4687,7 @@ static const struct ecoff_debug_swap mip
>>     standard ELF.  This structure is used to redirect the relocation
>>     handling routines.  */
>>  
>> -const struct elf_size_info mips_elf64_size_info =
>> +static const struct elf_size_info mips_elf64_size_info =
>>  {
>>    sizeof (Elf64_External_Ehdr),
>>    sizeof (Elf64_External_Phdr),
> 
>  Fine with me, thanks.  Using `-Wmissing-declarations' would help catch 
> these automatically if it handled global variables rather than functions 
> only (but sadly it doesn't and I seem unable to identify any alternative 
> compiler option to request doing so).
> 
>  NB Jeff's e-mail address is out of date in binutils/MAINTAINERS.

Yes, I too noticed this (afterwards). Nick is checking with him whether to
update the email references vs removing the entries.

Jan


More information about the Binutils mailing list