[PATCH 18/27] bfd/ELF: adjust *_size_info properties

Maciej W. Rozycki macro@orcam.me.uk
Mon Oct 27 17:49:39 GMT 2025


On Mon, 27 Oct 2025, Jan Beulich wrote:

> --- a/bfd/elf64-mips.c
> +++ b/bfd/elf64-mips.c
> @@ -4687,7 +4687,7 @@ static const struct ecoff_debug_swap mip
>     standard ELF.  This structure is used to redirect the relocation
>     handling routines.  */
>  
> -const struct elf_size_info mips_elf64_size_info =
> +static const struct elf_size_info mips_elf64_size_info =
>  {
>    sizeof (Elf64_External_Ehdr),
>    sizeof (Elf64_External_Phdr),

 Fine with me, thanks.  Using `-Wmissing-declarations' would help catch 
these automatically if it handled global variables rather than functions 
only (but sadly it doesn't and I seem unable to identify any alternative 
compiler option to request doing so).

 NB Jeff's e-mail address is out of date in binutils/MAINTAINERS.

  Maciej


More information about the Binutils mailing list