gas pointer to int and vice versa

Alan Modra amodra@gmail.com
Thu Jul 10 01:22:58 GMT 2025


On Wed, Jul 09, 2025 at 05:31:33PM +0100, Sam James wrote:
> "Maciej W. Rozycki" <macro@orcam.me.uk> writes:
> 
> > On Wed, 9 Jul 2025, Alan Modra wrote:
> >
> >> diff --git a/gas/config/tc-v850.c b/gas/config/tc-v850.c
> >> index b3440058756..09411767e7f 100644
> >> --- a/gas/config/tc-v850.c
> >> +++ b/gas/config/tc-v850.c
> >> @@ -3070,7 +3070,7 @@ md_assemble (char *str)
> >>  	      f = frag_var (rs_machine_dependent, 6, 2, SUBYPTE_LOOP_16_22,
> >>  			    fixups[0].exp.X_add_symbol,
> >>  			    fixups[0].exp.X_add_number,
> >> -			    (char *)(size_t) fixups[0].opindex);
> >> +			    (char *)(intptr_t) fixups[0].opindex);
> >
> >  Hmm, given that updates were made to the affected lines this piece and 
> > the rest of the changes applied to this file could have benefitted from 
> > fixing formatting to follow the GNU Coding Standards, i.e. adding the 
> > missing space after the first cast:
> >
> > 		    (char *) (intptr_t) fixups[0].opindex);
> >
> > but given that you've pushed it already I think the file will best remain 
> > as it is so as not to clutter `git blame' with syntactic noise.  Sigh.

For some reason I didn't see the above on my local machine, nor your
followup Maciej.  From mail logs it seems fetchmail didn't retrieve
the messages from gmail.  I wonder how much email I've been missing?

> I think the "Sigh." can come across as passive aggressive and is
> unhelpful.

I didn't take it that way, and I'll fix the formatting and apply Jan's
suggestion to use uintptr_t here.

-- 
Alan Modra


More information about the Binutils mailing list