Fix known minor objdump leak
Alan Modra
amodra@gmail.com
Wed Jan 15 11:48:12 GMT 2025
* objdump.c (main): Free disassembler_options.
diff --git a/binutils/objdump.c b/binutils/objdump.c
index 80044dea580..ebe586e0e3a 100644
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -6001,12 +6001,14 @@ main (int argc, char **argv)
{
char *options;
if (disassembler_options)
- /* Ignore potential memory leak for now. */
options = concat (disassembler_options, ",",
optarg, (const char *) NULL);
else
- options = optarg;
+ options = xstrdup (optarg);
+ free (disassembler_options);
disassembler_options = remove_whitespace_and_extra_commas (options);
+ if (!disassembler_options)
+ free (options);
}
break;
case 'j':
--
Alan Modra
More information about the Binutils
mailing list