[PATCH 34/34] rl78: drop redundant statement separator check

Jan Beulich jbeulich@suse.com
Wed Feb 19 15:41:14 GMT 2025


With the switch to the use of is_end_of_stmt() in 2dd0370c433d
("rl78: use is_whitespace()") the open-coded checking against
line_separator_chars[] can be dropped.
---
The checks against {,line_}comment_chars[] also look dubious to me:
Comments shouldn't make it here, as the scrubber eats them.

--- a/gas/config/tc-rl78.c
+++ b/gas/config/tc-rl78.c
@@ -431,8 +431,7 @@ require_end_of_expr (const char *fname)
   if (is_end_of_stmt (* input_line_pointer)
       || * input_line_pointer == ','
       || strchr (comment_chars, * input_line_pointer)
-      || strchr (line_comment_chars, * input_line_pointer)
-      || strchr (line_separator_chars, * input_line_pointer))
+      || strchr (line_comment_chars, * input_line_pointer))
     return;
 
   as_bad (_("%%%s() must be outermost term in expression"), fname);



More information about the Binutils mailing list