[PATCH] bfd: Re-enable 64-bit support for 32-bit Solaris targets

[Jan Beulich]

On 29.12.2025 11:24, Rainer Orth wrote:
> Hi Jan,
> 
>> On 28.12.2025 10:23, Rainer Orth wrote:
>>> One of the recent Solaris patches removed want64=true from the 32-bit
>>> Solaris targets.  This breaks GCC bootstrap: unlike Linux, GCC on
>>> Solaris is always biarch, both in 32-bit-default and 64-bit-default
>>> configurations, so the 64-bit multilib fails to build.
>>>
>>> This patch reenables this incompatible change.
>>
>> To further emphasize this (the comment you add already helps, yes), should
>> the entries also use targ_selvecs alone, not additionally targ64_selvecs?
>> As previously indicated, the setting of want64 looks wrong on the first
>> and second glance, because elsewhere it's tied to targ_selvecs containing
>> 64-bit targets.
> 
> when I look at the comment at the head of config.bfd, I'm not sure:
> 
> #  targ_selvecs		Vectors to build for this target
> #  targ64_selvecs	Vectors to build if --enable-64-bit-bfd is given
> #			or if host is 64 bit.
> 
> want64=true is the equivalent of --enable-64-bit-bfd,

Kind of, but not quite. want64= expresses our own intentions.

> which I used as a
> workaround before this patch.  This suggests that including the 64-bit
> vectors in targ64_selvecs is right.

If you don't, I may clean this up at some future point.

> Speaking of which: as I'd mentioned before, it would be good to also
> document the effects of BFD64 in the head comment, just to completely
> cover the settings.

As Alan already said, BFD64 is entirely meaningless in this script. It's
solely commentary.

Jan