[RFC 02/28] [SFrame-V3] libsframe: testsuite: add a new test for SFrame V2

[Jens Remus]

On 12/9/2025 10:07 AM, Indu Bhagat wrote:
> The existing frecnt-2.c testcase reads the SFrame section from the
> provided DATA2 buffer.  It exercises the sframe_decode (),
> sframe_decoder_get_num_fidx (), and sframe_decoder_get_funcdesc_v2 ()
> APIs.  Currently DATA2 file is the SFrame section created from the test
> input (mentioned in the comments in the file) in SFrame version 2.
> 
> Moving forward, creating SFrame V2 section via GNU assembler and GNU ld
> will not be supported.  But textual dump of SFrame V2 sections via
> readelf/objdump will need to be supported.  Add a test similar to
> frecnt-2.c using SFrame version 2 binary data to the libsframe
> testsuite.  Such a test will help ensure that sframe_decode () and
> related APIs remain tested for multiple supported arches till the
> support for V2 sections is to be maintained.
> 
> Duplicate frecnt-2.c to create a frecnt-v2.c, the latter will test with
> a SFrame V2 input section.
> 
> libsframe/
>         * Makefile.in: Regenerated.
> libsframe/testsuite/
>         * libsframe.decode/decode.exp: Likewise/
>         * libsframe.decode/local.mk: Likewise
>         * libsframe.decode/DATA-V2: New SFrame V2 test data file.
>         * libsframe.decode/frecnt-v2.c: New test.
> ---
>  libsframe/Makefile.in                         |  34 +++++++
>  libsframe/testsuite/libsframe.decode/DATA-V2  | Bin 0 -> 98 bytes
>  .../testsuite/libsframe.decode/decode.exp     |   6 ++
>  .../testsuite/libsframe.decode/frecnt-v2.c    |  90 ++++++++++++++++++
>  libsframe/testsuite/libsframe.decode/local.mk |   6 +-
>  5 files changed, 135 insertions(+), 1 deletion(-)
>  create mode 100644 libsframe/testsuite/libsframe.decode/DATA-V2
>  create mode 100644 libsframe/testsuite/libsframe.decode/frecnt-v2.c

Reviewed-by: Jens Remus <jremus@linux.ibm.com>

Regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303)
+49-7031-16-1128 Office
jremus@de.ibm.com

IBM

IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/