[PATCH] gas: stub out sframe-opt.c functions when SFrame is not supported

[Indu Bhagat]

On 12/18/25 11:43 PM, Jan Beulich wrote:
> On 18.12.2025 18:47, Indu Bhagat wrote:
>> On 12/15/25 2:58 AM, Jan Beulich wrote:
>>> Much like everything in gen-sframe.c, these functions are supposed to
>>> never be reached when SFrame isn't supported by a target. Adding
>>> respective assertions reduces code size for such targets, while at the
>>> same time adding consistency checking for targets which optionally
>>> support the feature.
>>>
>>> --- a/gas/sframe-opt.c
>>> +++ b/gas/sframe-opt.c
>>> @@ -21,6 +21,10 @@
>>>    #include "as.h"
>>>    #include "sframe.h"
>>>    
>>> +#ifndef support_sframe_p
>>> +# define support_sframe_p() false
>>> +#endif
>>> +
>>
>> What do you think about leaving a comment here (subset of the
>> information in commit log or verbatim) with the above definition.  I'm
>> thinking it may be confusing to see this macro defined to false in the
>> file.  Especially if the code evolves and there is need to rejig any of
>> support_sframe_p usage in other files.
> 
> I've added
> 
> /* Much like everything in gen-sframe.c, the functions here aren't supposed
>     to ever be reached when SFrame isn't supported by a target.  */
> 
> ahead of the #ifndef. Is that okay with you?
> 

Yes, Thanks.