[RFC 28/28] [SFrame-V3] Revert "gas: sframe: testsuite: add testcase for .cfi_register RA"

Indu Bhagat indu.bhagat@oracle.com
Wed Dec 10 07:25:57 GMT 2025


On 12/9/25 2:34 AM, Jan Beulich wrote:
> On 09.12.2025 10:07, Indu Bhagat via Binutils wrote:
>> This reverts commit b6265522917c513861db93c2c942368dfb14faec.
>>
>> The original commit is a part of the preparatory patch series for SFrame
>> V3.  The removed test is hence, not present on master.
> 
> None of the above makes clear why that commit would need reverting. (Also
> I take it that the commit message here would change once the prereq series
> has gone in.)
> 

Hi Jan,

Yes, the commit message will need to change.  I am now inclining towards 
removing the original addition of the testcase from the prereq patches...
(It existed at the time of posting as it saved me some rebase work.  A 
couple of patches add testcases to gas/testsuite/gas/cfi-sframe with 
numbered file name and touch gas/testsuite/gas/cfi-sframe/cfi-sframe.exp.)

As why this commit needs reverting:
The information that RA is to be recovered from a REG can be encoded 
using a "flexible" topmost frame representation in SFrame V3.  Such a 
frame is useful only when it is the topmost frame for stacktracer, if 
not, a stack tracer must not attempt using SFrame.

The specific support to handle .cfi_register directive was added in 
commit "gas: sframe: add handling for .cfi_register for FP and RA" and 
has its own testcase in that commit.

Thanks



More information about the Binutils mailing list