[PATCH] x86: replace XFAILs in "GOTX default" tests

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Thu Dec 4 15:43:43 GMT 2025


Hi Jan,

> The use of XFAIL was wrong here. XFAIL marks tests which in principle
> should work, but where making them work requires extra effort.
>
> --- a/gas/testsuite/gas/i386/gotx-default.d
> +++ b/gas/testsuite/gas/i386/gotx-default.d
> @@ -1,6 +1,6 @@
>  #source: gotx.s
>  #objdump: -dwr
> -#xfail: *-*-solaris*
> +#skip: *-*-solaris*
>  
>  .*: +file format .*
>  
> --- a/gas/testsuite/gas/i386/no-gotx-default.d
> +++ b/gas/testsuite/gas/i386/no-gotx-default.d
> @@ -1,7 +1,6 @@
>  #source: gotx.s
>  #objdump: -dwr
> -#xfail: *-*-*
> -#noxfail: *-*-solaris*
> +#noskip: *-*-solaris*
>  
>  .*: +file format .*

this is wrong: the tests are intended to verify that the
-mrelax-relocations defaut remains as desired (off on Solaris, on
elsewhere).  With xfail's, any change results in an XPASS, while with
skip's the change goes unnoticed because the tests are never run.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


More information about the Binutils mailing list