[PATCH 6/7] RISC-V: use is_whitespace()

[Nelson Chu]

On Wed, Aug 21, 2024 at 5:39 PM Jan Beulich <jbeulich@suse.com> wrote:

> On 21.08.2024 10:37, Nelson Chu wrote:
> > umm I apply the patch and then get the following errors,
> > error: call to undeclared function 'is_whitespace'; ISO C99 and later do
> > not support implicit function declarations
>
> Did you apply this patch just on its own? It depends on patch 2 in this
> series.
>

Oops, yeah...


>
> > Personally, also considering the file compatibility, maybe ISSPACE is a
> > good way to go.  But if the above error can be resolved, in fact both
> look
> > better then the old code.
>
> As mentioned in the cover letter, ISSPACE() is likely wrong. If anything,
> it more likely wants to be ISBLANK(). And yes, as per the discussion
> hanging off of the cover letter, the goal is to make whitespace checking
> uniform in gas - either all ISBLANK() or all is_whitespace(). As per what
> I said in reply there, I'm slightly in favor of the latter, but arguments
> towards the former (somehow addressing my slight concern of having a
> dependency on libiberty for something that maybe would better be fully
> controlled internally to gas) could result in my position moving.
>

I don't have a strong opinion here, so both look good to me.

Thanks
Nelson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/binutils/attachments/20240903/080e71b2/attachment.htm>