[PATCH] Support APX CCMP and CTEST

Jan Beulich jbeulich@suse.com
Thu May 30 15:17:01 GMT 2024


On 30.05.2024 08:58, Cui, Lili wrote:
>>>>> +    as_bad (_("same oszc flag used twice"));
>>>>> +  i.oszc_flags |= 1 << oszc_shift;
>>>>> +}
>>>>> +
>>>>>  /* Handle SCC OSZC flags.  */
>>>>>
>>>>>  static int
>>>>> @@ -1999,16 +2006,16 @@ check_Scc_OszcOperations (const char *l)
>>>>>            switch (suffix_string[0])
>>>>>              {
>>>>>              case 'o':
>>>>> -              i.oszc_flags |= (1 << OF);
>>>>> +             set_oszc_flags (OF);
>>>>>                break;
>>>>>              case 's':
>>>>> -              i.oszc_flags |= (1 << SF);
>>>>> +             set_oszc_flags (SF);
>>>>>                break;
>>>>>              case 'z':
>>>>> -              i.oszc_flags |= (1 << ZF);
>>>>> +             set_oszc_flags (ZF);
>>>>>                break;
>>>>>              case 'c':
>>>>> -              i.oszc_flags |= (1 << CF);
>>>>> +             set_oszc_flags (CF);
>>>>>                break;
>>>>>              default:
>>>>
>>>> ... this looks okay to me (still pending the rename of the constant
>>>> names, though).
>>>
>>> I think you mean const char *l (suffix_string),
>>
>> No, I mean the CF, ZF, etc constants.
> 
> Do you have any suggestions for new names?

I already suggested to name them OSZC_CF etc.

Jan


More information about the Binutils mailing list