[PATCH] Support APX CCMP and CTEST

Cui, Lili lili.cui@intel.com
Thu May 30 06:58:10 GMT 2024


> >>> +    as_bad (_("same oszc flag used twice"));
> >>> +  i.oszc_flags |= 1 << oszc_shift;
> >>> +}
> >>> +
> >>>  /* Handle SCC OSZC flags.  */
> >>>
> >>>  static int
> >>> @@ -1999,16 +2006,16 @@ check_Scc_OszcOperations (const char *l)
> >>>            switch (suffix_string[0])
> >>>              {
> >>>              case 'o':
> >>> -              i.oszc_flags |= (1 << OF);
> >>> +             set_oszc_flags (OF);
> >>>                break;
> >>>              case 's':
> >>> -              i.oszc_flags |= (1 << SF);
> >>> +             set_oszc_flags (SF);
> >>>                break;
> >>>              case 'z':
> >>> -              i.oszc_flags |= (1 << ZF);
> >>> +             set_oszc_flags (ZF);
> >>>                break;
> >>>              case 'c':
> >>> -              i.oszc_flags |= (1 << CF);
> >>> +             set_oszc_flags (CF);
> >>>                break;
> >>>              default:
> >>
> >> ... this looks okay to me (still pending the rename of the constant
> >> names, though).
> >
> > I think you mean const char *l (suffix_string),
> 
> No, I mean the CF, ZF, etc constants.

Do you have any suggestions for new names? Or just use the immediate value.
 
    /* Store 4 bits of EVEX.[OF,SF,ZF,CF].  */
#define CF 0
#define ZF 1
#define SF 2
#define OF 3
    unsigned int oszc_flags;

Thanks,
Lili.



More information about the Binutils mailing list