Experimental Support for Microblaze 64-bit Architecture - binutils and gdb
Michael Eager
eager@eagerm.com
Wed Jul 17 17:12:26 GMT 2024
On 7/16/24 22:10, Gopi Kumar Bulusu wrote:
>> Separate out bug fix patches and submit them independently. Each bug
>> fix patch should include a test case. A Big Wad Of Stuff patch
>> addressing multiple bugs and new arch support is not very welcome.
>
>
> I will have to try and identify a strategy that conforms to your suggestion.
>
> The total number of incoming patches as of december 2023 - binutils
> (34) gdb (8) [ mutually conflicting ] ,
> the total number of outgoing patches (after the above described process)
> - 52 and a few more as
> the sub-test-case level regressions are addressed.
I have limited time to review patches. Patches which address multiple
bugs take much longer to review and may result in you being asked to
split them into separate independent patches. It's clearly more
efficient if you do this in advance, rather than after I spend time on
review.
If you plan to submit a number of patches at one time, it is best if
they are independent. That allows patches to be reviewed independently,
so that changes needed in one patch don't block review of other patches.
If you have patches which are dependent on prior patches, it may be
better to hold submitting these until the prerequisite patches are
approved.
My suggestions are that you make sure that each patch applies to the top
of the repo tree, that there is a clear description of the patch (what
bug it fixes or what improvement it makes), and a test case which fails
without the bug fix and passes with it.
Let me know if you have questions or if there is any way I can help.
-- Michael Eager
More information about the Binutils
mailing list