[PATCH v2 1/9] x86: Remove unused SFrame CFI RA register variable

[Jan Beulich]

On 27.02.2024 10:08, Indu Bhagat wrote:
> On 2/26/24 05:01, Jan Beulich wrote:
>> On 24.02.2024 08:38, Indu Bhagat wrote:
>>> On 2/23/24 09:07, Jens Remus wrote:
>>>> gas/
>>>> 	* config/tc-i386.c: Remove unused SFrame CFI RA register
>>>> 	  variable.
>>>>
>>>
>>> The ChangeLog formatting is a bit off here and in the rest of the
>>> patches in this series.
>>>
>>> The indentation of each line should be such that all content lines up
>>> below the *, like so:
>>>
>>> <TAB>* xyz.c: first line content
>>> <TAB>next line content
>>>
>>> Other than that, LGTM.
>>
>> Just to clarify: It's not actually a missing SFRAME_CFA_RA_REG define
>> (and initialization of the variable)?
>>
> 
> For architectures where return address is at a fixed offset from CFA, 
> like x86, it made sense to not define and initialize SFRAME_CFA_RA_REG.
> 
> So, the variable x86_sframe_cfa_ra_reg was unused and unnecessary.

Okay. So Jens - feel free to put in.

Jan