[PATCH v2 1/9] x86: Remove unused SFrame CFI RA register variable

Jens Remus jremus@linux.ibm.com
Mon Feb 26 15:04:13 GMT 2024


Am 24.02.2024 um 08:38 schrieb Indu Bhagat:
> On 2/23/24 09:07, Jens Remus wrote:
>> gas/
>>     * config/tc-i386.c: Remove unused SFrame CFI RA register
>>       variable.
>>
> 
> The ChangeLog formatting is a bit off here and in the rest of the 
> patches in this series.
> 
> The indentation of each line should be such that all content lines up 
> below the *, like so:
> 
> <TAB>* xyz.c: first line content
> <TAB>next line content

Thanks for letting me know! Have corrected that in the whole series.

> Other than that, LGTM.

Thank you for the review! Will wait for your response on Jan's question 
before pushing it to master.

> 
> Thanks
> Indu
> 
>> Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com>
>> Signed-off-by: Jens Remus <jremus@linux.ibm.com>
>> ---
>>   gas/config/tc-i386.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
>> index c56ca4a2b4b8..1a6fd52f229a 100644
>> --- a/gas/config/tc-i386.c
>> +++ b/gas/config/tc-i386.c
>> @@ -627,7 +627,6 @@ static int shared = 0;
>>   unsigned int x86_sframe_cfa_sp_reg;
>>   /* The other CFA base register for SFrame stack trace info.  */
>>   unsigned int x86_sframe_cfa_fp_reg;
>> -unsigned int x86_sframe_cfa_ra_reg;
>>   #endif

Regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303) and z/VSE Support
+49-7031-16-1128 Office
jremus@de.ibm.com

IBM

IBM Deutschland Research & Development GmbH; Vorsitzender des 
Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der 
Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/


More information about the Binutils mailing list