[PATCH v2 1/2] bfd: microblaze: Add 32_NONE reloc type
Nick Clifton
nickc@redhat.com
Fri Nov 10 14:27:29 GMT 2023
Hi Neal,
> This patch adds the R_MICROBLAZE_32_NONE relocation type.
> This is a 32-bit reloc that stores the 32-bit pc relative
> value in two words (with an imm instruction).
Patch approved - please apply, but with one small change:
> for (irelscan = irelocs; irelscan < irelscanend; irelscan++)
> {
> - if (ELF32_R_TYPE (irelscan->r_info) == (int) R_MICROBLAZE_32)
> + if ((ELF32_R_TYPE (irelscan->r_info) == (int) R_MICROBLAZE_32) ||
> + (ELF32_R_TYPE (irelscan->r_info) ==
> + (int) R_MICROBLAZE_32_NONE))
> {
Formatting: please do not end a line with a logical operator, in this case: ||
Instead please move the operator to the start of the next line.
Cheers
Nick
More information about the Binutils
mailing list