[PATCH v2 0/5] Some MIPS changes and testsuite fixes

Maciej W. Rozycki macro@orcam.me.uk
Thu Jun 15 03:51:07 GMT 2023


On Wed, 31 May 2023, Maciej W. Rozycki wrote:

> > > I applied your patchset and ran my usual regression tests over some
> > > 165 different binutils targets.  mipsisa32r2el-elf, mips-sgi-irix6,
> > > and mipstx39-elf show some new failures.  This doesn't mean I
> > > disapprove the patch, in fact I like it!  Please don't think you must
> > > post another version of the patchset to fix these problems.  It might
> > > be better to solve them with an incremental patch, giving the mips
> > > maintainers a chance to review this patchset first.
> > 
> > If there is no objection, I will commit this patchset and go on to solve
> > the problem Alan pointed out.
> 
>  Well, it does have to be reviewed, especially as there are changes beyond 
> just testsuite fixes.

 I have now reverted these changes, as they were committed unapproved and 
I haven't heard back from you in response to my question sent off list.  

 If you want this patch set in, then please repost it, get reviewed *and*
approved, and only then you can commit it.  Thank you.

  Maciej


More information about the Binutils mailing list