[PATCH] gas: documents .gnu_attribute Tag_GNU_MIPS_ABI_MSA

Maciej W. Rozycki macro@orcam.me.uk
Thu Jun 15 03:50:51 GMT 2023


On Fri, 19 May 2023, Maciej W. Rozycki wrote:

>  Also your change is actually not obviously correct, because it has a
> defect in formatting: an overlong line that exceeds 79 columns (staying 
> within 74 is preferred where feasible).
> 
>  Finally for a non-native English speaker it's always good to have 
> documentation changes reviewed as this is what our users will read, and 
> the last thing we want is documentation that seems unprofessional.  In 
> this case you have an inconsistency between the two cases: one uses the 
> singular and the other one uses the plural form of the noun, which is bad 
> style.  I find the style of the commit description so-so as well.  Being 
> internal only it's less of a problem, albeit unfixable once pushed.

 I have now committed a fix addressing the defects with your change.  In a 
detailed review, which should have happened *before* your change went in, 
it has turned out the whole paragraph was inconsistent with one covering 
Tag_GNU_MIPS_ABI_FP immediately above.  I have rewritten it accordingly.

  Maciej


More information about the Binutils mailing list