[PATCH, V2 10/15] gdb: sim: buildsystem changes to accommodate libsframe

[Indu Bhagat]

On 10/27/22 10:36, Mike Frysinger wrote:
> On 17 Oct 2022 15:16, Indu Bhagat via Binutils wrote:
>> --- a/gdb/configure.ac
>> +++ b/gdb/configure.ac
>> @@ -2167,6 +2167,17 @@ fi
>>   AC_SUBST(LIBCTF)
>>   AC_SUBST(CTF_DEPS)
>>   
>> +GCC_ENABLE([libsframe], [yes], [], [Handle .sframe sections])
>> +if test x${enable_static} = xno; then
>> +  LIBSFRAME="-Wl,--rpath,../libsframe/.libs ../libsframe/.libs/libsframe.so"
>> +  SFRAME_DEPS="../libsframe/.libs/libsframe.so"
>> +else
>> +  LIBSFRAME="../libsframe/.libs/libsframe.a"
>> +  SFRAME_DEPS="$LIBSFRAME"
>> +fi
> 
> this logic is not portable.  you're using libtool to generate this library,
> but then trying to go behind its back and hardcode paths that only libtool
> is supposed to know about.
> 
> the "libsframe.so" path doesn't work on macOS, Windows, etc...
> -mike

Thanks. I have removed it in V3 (that I will send next). It didn't make 
sense to have added this in the first place. libsframe is required for 
encoder/decoder support and as such cannot be disabled from the build as 
it is now needed by libbfd.

Indu