[PATCH, V2 10/15] gdb: sim: buildsystem changes to accommodate libsframe

[Mike Frysinger]

On 17 Oct 2022 15:16, Indu Bhagat via Binutils wrote:
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -2167,6 +2167,17 @@ fi
>  AC_SUBST(LIBCTF)
>  AC_SUBST(CTF_DEPS)
>  
> +GCC_ENABLE([libsframe], [yes], [], [Handle .sframe sections])
> +if test x${enable_static} = xno; then
> +  LIBSFRAME="-Wl,--rpath,../libsframe/.libs ../libsframe/.libs/libsframe.so"
> +  SFRAME_DEPS="../libsframe/.libs/libsframe.so"
> +else
> +  LIBSFRAME="../libsframe/.libs/libsframe.a"
> +  SFRAME_DEPS="$LIBSFRAME"
> +fi

this logic is not portable.  you're using libtool to generate this library,
but then trying to go behind its back and hardcode paths that only libtool
is supposed to know about.

the "libsframe.so" path doesn't work on macOS, Windows, etc...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20221027/333779d3/attachment.sig>