[PATCH] windres: add quotes around preprocessor cmd if needed

[Clément Chigot]

On Tue, Jun 28, 2022 at 11:00 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 28.06.2022 09:35, Clément Chigot via Binutils wrote:
> > This patch ensures that the gcc binary called by windres is quoted if
> > needed. Otherwise, errors can occur if the gcc is under a folder having
> > a name containing a space (eg "Program Files").
> >
> > binutils/
> >         * resrc.c (DEFAULT_PREPROCESSOR): Split into...
> >         (DEFAULT_PREPROCESSOR_CMD): that...
> >         (DEFAULT_PREPROCESSOR_ARGS): and that.
> >         (look_for_default): Add quotes around the command if needed.
> >         (read_rc_file): Adapt to new defines.
>
> Commenting is a little difficult without you providing the patch (also)
> inline:

IIRC, it should be done directly but the "é" in my name makes the
mailservers think my patches are binaries...

Shouldn't you also (optionally) quote the pre-processor string
> if that came into read_rc_file() as non-NULL? Everything else looks
> okay to me.

Yeah. I didn't run into this issue but looking at the code it should happen
too. Thanks for pointing it out !

Clément