[PATCH] windres: add quotes around preprocessor cmd if needed

Jan Beulich jbeulich@suse.com
Tue Jun 28 09:00:18 GMT 2022


On 28.06.2022 09:35, Clément Chigot via Binutils wrote:
> This patch ensures that the gcc binary called by windres is quoted if
> needed. Otherwise, errors can occur if the gcc is under a folder having
> a name containing a space (eg "Program Files").
> 
> binutils/
>         * resrc.c (DEFAULT_PREPROCESSOR): Split into...
>         (DEFAULT_PREPROCESSOR_CMD): that...
>         (DEFAULT_PREPROCESSOR_ARGS): and that.
>         (look_for_default): Add quotes around the command if needed.
>         (read_rc_file): Adapt to new defines.

Commenting is a little difficult without you providing the patch (also)
inline: Shouldn't you also (optionally) quote the pre-processor string
if that came into read_rc_file() as non-NULL? Everything else looks
okay to me.

Jan


More information about the Binutils mailing list