PR15951, binutils testsuite builds status wrapper unconditionally

Alan Modra amodra@gmail.com
Fri Jul 22 02:28:36 GMT 2022


This bug has been sitting in bugzilla, with a patch (different to this
one, I'm copying from gdb) for 3234 days.  Which says we don't have
enough competent people looking at bugzilla.  Please help out if you
can.

	PR 15951
	* testsuite/binutils-all/objcopy.exp: Build testglue.o when
	needs_status_wrapper.

diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp
index 9a5dad5384e..5871d431eea 100644
--- a/binutils/testsuite/binutils-all/objcopy.exp
+++ b/binutils/testsuite/binutils-all/objcopy.exp
@@ -641,7 +641,12 @@ proc copy_setup { } {
     global test_prog
     global host_triplet
 
-    set res [build_wrapper testglue.o]
+    if {[target_info exists needs_status_wrapper] && \
+	    [target_info needs_status_wrapper] != "0"} {
+	set res [build_wrapper testglue.o]
+    } else {
+	set res ""
+    }
     set flags { debug }
 
     if { [istarget *-*-uclinux*] && ![istarget tic6x-*-*] && ![istarget arm*-*-uclinuxfdpiceabi] } {

-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list