About 329338 - Declaration conflict for basename

[Vladimir Mezentsev]

On 7/14/22 00:35, Alan Modra wrote:
> On Wed, Jul 13, 2022 at 11:41:49PM -0700, Vladimir Mezentsev via Binutils wrote:
>> Hi team,
>>
>> I am evaluating 29338 - Declaration conflict for basename
>> <https://sourceware.org/bugzilla/show_bug.cgi?id=29338>
>> and I see a regression in the efbecf1e953 commit.
>>
>> % git log --pretty=format:"%h - %an, %ar --> %s" --graph --name-status*
>> ...
>>   efbecf1e953 - Nick Clifton, 6 days ago --> Update version number|
>> | M     bfd/configure
>> | M     bfd/po/bfd.pot
>> | M     bfd/version.m4
>> | M     binutils/configure
>> | M     binutils/po/binutils.pot
>> | M     gas/configure
>> | M     gas/po/gas.pot
>> | M     gold/po/gold.pot
>> | M     gprof/configure
>> | M     gprof/po/gprof.pot
>> | M     gprofng/common/config.h.in       <---------------- This update is
>> wrong.
> Did commit b95830931f fix the problem?

I don't know. This commit is in the master branch.
I  klnow the master branch has no problems now.
I know If I run:
    cd gprofng;
   autoreconf
this fiixes problem.

Somehow Nick Clifton updated gprofng/common/config.h.in differently.
Maybe `cd gprofng/libcollector && autoreconf`


In any case,  we need to fix gprofng/libcollector/configure.ac.
For the  binutils-2_39-branch branch, we can rerun `cd gprofng && 
autoreconf`. This fixes build.

-Vladimir




>